Make the Makefile build fully customizable #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 33.93% // Head: 33.93% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 33.93% 33.93%
=======================================
Files 42 42
Lines 8080 8080
=======================================
Hits 2742 2742
Misses 5121 5121
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nyoxi
requested changes
Jan 17, 2023
ahadas
approved these changes
Jan 18, 2023
mmartinv
force-pushed
the
makefile-changes
branch
from
ed7f765
to
296d27c
Compare
nyoxi
reviewed
Jan 18, 2023
mmartinv
force-pushed
the
makefile-changes
branch
2 times, most recently
from
f23cd8a
to
0ab4a00
Compare
nyoxi
reviewed
Jan 19, 2023
mmartinv
force-pushed
the
makefile-changes
branch
from
0ab4a00
to
71b3090
Compare
mmartinv
force-pushed
the
makefile-changes
branch
2 times, most recently
from
7506ffe
to
6da8cf7
Compare
nyoxi
requested changes
Jan 19, 2023
mmartinv
force-pushed
the
makefile-changes
branch
2 times, most recently
from
cec0f7f
to
12f9f5d
Compare
nyoxi
approved these changes
Jan 19, 2023
ahadas
force-pushed
the
makefile-changes
branch
from
12f9f5d
to
1184755
Compare
ahadas
reviewed
Jan 22, 2023
mmartinv
force-pushed
the
makefile-changes
branch
from
1184755
to
2ef21e7
Compare
mmartinv
force-pushed
the
makefile-changes
branch
from
2ef21e7
to
6151414
Compare
ahadas
reviewed
Jan 25, 2023
.bazelrc
Outdated
| @@ -1,3 +1,6 @@ | |||
| # Container Runtime | |||
| build --action_env=CONTAINER_CMD=/usr/bin/docker | |||
There was a problem hiding this comment.
In case both docker and podman are installed this is used to force the use of one of them. This could be useful to test builds with both container runtimes without having to remove podman to test docker.
mmartinv
force-pushed
the
makefile-changes
branch
from
6151414
to
f5a997e
Compare
mmartinv
force-pushed
the
makefile-changes
branch
2 times, most recently
from
215d528
to
84b8498
Compare
ahadas
force-pushed
the
makefile-changes
branch
from
84b8498
to
0b39ecb
Compare
mmartinv
force-pushed
the
makefile-changes
branch
3 times, most recently
from
8ef8e02
to
99c3470
Compare
ahadas
approved these changes
Jan 26, 2023
mnecas
reviewed
Jan 26, 2023
mmartinv
force-pushed
the
makefile-changes
branch
from
99c3470
to
4a0e3db
Compare
Prefer `podman` over `docker`. Make the build fully customizable through environment variables. Use `CONTROLLER_GEN` var to specify which `controller-gen` binary must be used and make sure the correct version is installed when using the default one. Make consistent use of parentheses instead of curly braces for variable delimitation. Add sandbox writeable paths, needed after `bazel clean`. Signed-off-by: Miguel Martín <mmartinv@redhat.com>
mmartinv
force-pushed
the
makefile-changes
branch
from
4a0e3db
to
612269a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mnecas
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podmanoverdockerin Makefile buildsvariables.
CONTROLLER_GENvar to specify whichcontroller-genbinary must be used and make sure the correct version is
installed when using the default one.
for variable delimitation.
bazel clean.